[Containerapp] az containerapp env premium-ingress#8677
[Containerapp] az containerapp env premium-ingress#8677zhoxing-ms merged 24 commits intoAzure:mainfrom
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp env premium-ingress | sub group containerapp env premium-ingress added |
|
Hi @Tratcher, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Greedygre,
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
Co-authored-by: Craig Shoemaker <craig@craigshoemaker.net>
Tratcher
force-pushed
the
ingress-configuration-for-containerapp
branch
from
688370a to
716dc61
Compare
|
Here is the PR to update api-version to 2025-02-02-preview: #8791 |
Tratcher
force-pushed
the
ingress-configuration-for-containerapp
branch
from
0c018bc to
2696bd3
Compare
|
=========================== short test summary info ============================ E vcr.errors.CannotOverwriteExistingCassetteException: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_premium_ingress_commands.yaml') in your current record mode ('once'). Hi @Tratcher Seems your azure-cli dev branch need to pull the latest code and set_up again. |
| logs_workspace_name = self.create_random_name(prefix='containerapp-env', length=24) | ||
|
|
||
| logs_workspace_id = self.cmd(f'monitor log-analytics workspace create -g {resource_group} -n {env_name} -l eastus'.format(resource_group, logs_workspace_name)).get_output_in_json()["customerId"] | ||
| logs_workspace_key = self.cmd(f'monitor log-analytics workspace get-shared-keys -g {resource_group} -n {env_name}'.format(resource_group, logs_workspace_name)).get_output_in_json()["primarySharedKey"] |
There was a problem hiding this comment.
You don't need log workspace right?
You can set --logs-destination none to avoid input not needed resource
| env = ManagedEnvironmentPreviewClient.show(cmd, resource_group_name, name) | ||
| if not env: | ||
| raise ResourceNotFoundError(f"The containerapp environment '{name}' does not exist") |
There was a problem hiding this comment.
ni: the if not env is not works when resource group not exists or environment not exists
az containerapp env premium-ingress show -n a -g b
Command group 'containerapp env premium-ingress' is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
(ResourceGroupNotFound) Resource group 'b' could not be found.
az containerapp env premium-ingress show -n a -g arcenv-xinyu1-rg
Command group 'containerapp env premium-ingress' is in preview and under development. Reference and support levels: https://aka.ms/CLI_refstatus
(ResourceNotFound) The Resource 'Microsoft.App/managedEnvironments/a' under resource group 'arcenv-xinyu1-rg' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py
Show resolved
Hide resolved
| g.custom_show_command('show', 'show_environment_premium_ingress') | ||
| g.custom_command('add', 'add_environment_premium_ingress') | ||
| g.custom_command('update', 'update_environment_premium_ingress') | ||
| g.custom_command('remove', 'remove_environment_premium_ingress') |
There was a problem hiding this comment.
For remove command, we should have , confirmation=True
Greedygre
left a comment
Greedygre
left a comment
There was a problem hiding this comment.
Please fix the CI and add , confirmation=True to remove command
Rebase root repo. Recording updates
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
6 participants
Enables configuring the new environment premium ingress settings.
Continues https://github.com/Azure/azure-cli-extensions/pull/8670/files
Related command
az containerapp env premium-ingress
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)